Fix the command buffer scheduling pass return value #17257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezhulenev
approved these changes
Sep 17, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
Imported from GitHub PR #17257 Fixes #17216. Returns true when either parameters are moved, or command buffer is created. Copybara import of the project: -- f9dc3e2 by Shraiysh Vaishay <[email protected]>: Fix the command buffer scheduling pass return value Fixes #17216. Returns true when either parameters are moved, or command buffer is created. Merging this change closes #17257 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17257 from shraiysh:fix_17216 f9dc3e2 PiperOrigin-RevId: 675625838
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 17, 2024
Imported from GitHub PR openxla/xla#17257 Fixes #17216. Returns true when either parameters are moved, or command buffer is created. Copybara import of the project: -- f9dc3e277e414e8d1de423221ca3e2d9b0ae3c9e by Shraiysh Vaishay <[email protected]>: Fix the command buffer scheduling pass return value Fixes #17216. Returns true when either parameters are moved, or command buffer is created. Merging this change closes #17257 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17257 from shraiysh:fix_17216 f9dc3e277e414e8d1de423221ca3e2d9b0ae3c9e PiperOrigin-RevId: 675625838
shraiysh
force-pushed
the
fix_17216
branch
2 times, most recently
from
c4fb29c
to
17c6537
Compare
|
The clang format failure was unrelated but I fixed it in this PR itself. It is just a change of spaces. |
Fixes openxla#17216. Returns true when either parameters are moved, or command buffer is created.
ezhulenev
approved these changes
Sep 19, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Imported from GitHub PR #17257 Fixes #17216. Returns true when either parameters are moved, or command buffer is created. Copybara import of the project: -- 410974f by Shraiysh Vaishay <[email protected]>: Fix the command buffer scheduling pass return value Fixes #17216. Returns true when either parameters are moved, or command buffer is created. Merging this change closes #17257 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17257 from shraiysh:fix_17216 410974f PiperOrigin-RevId: 675625838
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 19, 2024
Imported from GitHub PR openxla/xla#17257 Fixes #17216. Returns true when either parameters are moved, or command buffer is created. Copybara import of the project: -- 410974f533c1846386f001ed97d93a8291e77b1a by Shraiysh Vaishay <[email protected]>: Fix the command buffer scheduling pass return value Fixes #17216. Returns true when either parameters are moved, or command buffer is created. Merging this change closes #17257 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17257 from shraiysh:fix_17216 410974f533c1846386f001ed97d93a8291e77b1a PiperOrigin-RevId: 675625838
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Imported from GitHub PR #17257 Fixes #17216. Returns true when either parameters are moved, or command buffer is created. Copybara import of the project: -- 410974f by Shraiysh Vaishay <[email protected]>: Fix the command buffer scheduling pass return value Fixes #17216. Returns true when either parameters are moved, or command buffer is created. Merging this change closes #17257 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17257 from shraiysh:fix_17216 410974f PiperOrigin-RevId: 675625838
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 20, 2024
Imported from GitHub PR openxla/xla#17257 Fixes #17216. Returns true when either parameters are moved, or command buffer is created. Copybara import of the project: -- 410974f533c1846386f001ed97d93a8291e77b1a by Shraiysh Vaishay <[email protected]>: Fix the command buffer scheduling pass return value Fixes #17216. Returns true when either parameters are moved, or command buffer is created. Merging this change closes #17257 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17257 from shraiysh:fix_17216 410974f533c1846386f001ed97d93a8291e77b1a PiperOrigin-RevId: 675625838
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 20, 2024
Imported from GitHub PR openxla/xla#17257 Fixes #17216. Returns true when either parameters are moved, or command buffer is created. Copybara import of the project: -- 410974f533c1846386f001ed97d93a8291e77b1a by Shraiysh Vaishay <[email protected]>: Fix the command buffer scheduling pass return value Fixes #17216. Returns true when either parameters are moved, or command buffer is created. Merging this change closes #17257 PiperOrigin-RevId: 676782971
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 20, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17257 from shraiysh:fix_17216 410974f533c1846386f001ed97d93a8291e77b1a PiperOrigin-RevId: 676423808
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 20, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17257 from shraiysh:fix_17216 410974f533c1846386f001ed97d93a8291e77b1a PiperOrigin-RevId: 676619222
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 20, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17257 from shraiysh:fix_17216 410974f533c1846386f001ed97d93a8291e77b1a PiperOrigin-RevId: 676618002
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 20, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17257 from shraiysh:fix_17216 410974f533c1846386f001ed97d93a8291e77b1a PiperOrigin-RevId: 676618016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17216. Returns true when either parameters are moved, or command buffer is created.